Line up the wrapped lines of a quote #340

Merged

robbertbos merged 1 commit from worktree-text-editor-verbeteren into main 2026-09-19 14:28:05 +00:00

Conversation 0 Commits 1 Files changed 3 +56 -13

robbertbos commented 2026-08-20 20:30:17 +00:00

Owner

Copy link

The second line of a wrapped quote sat 19.2px to the right of the first, and the first line jumped by that same amount the moment the caret left it.

NLDD reserves the width of the > with padding-left and pulls the first line back over it with a negative text-indent, so the marker hangs in a gutter. We hide that marker, so the pull-back has nothing to hang and only the first visual row moves left. Dropping the pull-back where the marker is hidden, while keeping the reserved padding, puts every row where the revealed state already put the text.

Measured on the built bundle, x of each visual row of a wrapping quote line:

	before	after
marker hidden	187 / 187 / 206.2	206.2 / 206.2 / 206.2
marker revealed	187 / 206.2 / 206.2	187 / 206.2 / 206.2

So the wrapped row lines up, and the jump on caret entry/exit is gone too.

!important is load-bearing here: NLDD writes the indent as an inline style, and author !important is the one thing that outranks it. The view plugin now rebuilds on selectionSet as well, because the caret decides whether the marker is on screen.

The second line of a wrapped quote sat 19.2px to the right of the first, and the first line jumped by that same amount the moment the caret left it. NLDD reserves the width of the `> ` with `padding-left` and pulls the first line back over it with a negative `text-indent`, so the marker hangs in a gutter. We hide that marker, so the pull-back has nothing to hang and only the first visual row moves left. Dropping the pull-back where the marker is hidden, while keeping the reserved padding, puts every row where the revealed state already put the text. Measured on the built bundle, x of each visual row of a wrapping quote line: | | before | after | | --- | --- | --- | | marker hidden | 187 / 187 / 206.2 | 206.2 / 206.2 / 206.2 | | marker revealed | 187 / 206.2 / 206.2 | 187 / 206.2 / 206.2 | So the wrapped row lines up, and the jump on caret entry/exit is gone too. `!important` is load-bearing here: NLDD writes the indent as an inline style, and author `!important` is the one thing that outranks it. The view plugin now rebuilds on `selectionSet` as well, because the caret decides whether the marker is on screen.

robbertbos force-pushed worktree-text-editor-verbeteren from 9a8c33c1bf to a6e0882534 2026-09-05 11:32:48 +00:00 Compare

robbertbos force-pushed worktree-text-editor-verbeteren from a6e0882534 to aa1edfec9e 2026-09-19 12:41:35 +00:00 Compare

robbertbos force-pushed worktree-text-editor-verbeteren from aa1edfec9e to 167b7a89b3 2026-09-19 13:35:08 +00:00 Compare

robbertbos force-pushed worktree-text-editor-verbeteren from 167b7a89b3 to 9a6650e0b8 2026-09-19 13:48:07 +00:00 Compare

robbertbos merged commit 9a6650e0b8 into main 2026-09-19 14:28:05 +00:00

robbertbos deleted branch worktree-text-editor-verbeteren 2026-09-19 14:28:05 +00:00

robbertbos referenced this pull request 2026-09-19 14:34:39 +00:00

Indent a quote by its depth, not by its marker's width #364

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

nldd ds

  

question

More information is needed

  

wontfix

This won't be fixed

No labels

bug

duplicate

enhancement

help wanted

invalid

nldd ds

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

robbertbos/waggle!340

No description provided.