Indent a quote by its depth, not by its marker's width #364

Merged

robbertbos merged 1 commit from quote-indent-by-depth into main 2026-09-19 14:39:57 +00:00

Conversation 0 Commits 1 Files changed 4 +46 -22

robbertbos commented 2026-09-19 14:34:39 +00:00

Owner

Copy link

Follow-up to #340. With the > hidden, >tekst sat one character in and > tekst two, because NLDD sizes the hanging indent by the prefix's character count. A quote now indents by depth (the number of >), in both caret states: >tekst and > tekst line up, >> tekst sits one step further, and entering or leaving the line does not move the text.

Measured in the preview at 480px: every row of >een and > twee at 71.6px, >> drie at 81.2px; with the caret on the > twee line its first letter sits at 71.7px.

Trade-off: with the caret on a > line, the revealed marker hangs 1.4px from the bar. Kept that way because the text now sits at the smaller indent.

nlddTokens.test.ts never saw --_* variables (no _ in its regexes). This reads NLDD's internal --_marker-advance, so the guard now covers it: green with the real name, red with a misspelled one.

Gates: 1424 vitest, 122 e2e, typecheck, pre-commit.

Follow-up to #340. With the `>` hidden, `>tekst` sat one character in and `> tekst` two, because NLDD sizes the hanging indent by the prefix's character count. A quote now indents by depth (the number of `>`), in both caret states: `>tekst` and `> tekst` line up, `>> tekst` sits one step further, and entering or leaving the line does not move the text. Measured in the preview at 480px: every row of `>een` and `> twee` at 71.6px, `>> drie` at 81.2px; with the caret on the `> twee` line its first letter sits at 71.7px. Trade-off: with the caret on a `> ` line, the revealed marker hangs 1.4px from the bar. Kept that way because the text now sits at the smaller indent. `nlddTokens.test.ts` never saw `--_*` variables (no `_` in its regexes). This reads NLDD's internal `--_marker-advance`, so the guard now covers it: green with the real name, red with a misspelled one. Gates: 1424 vitest, 122 e2e, typecheck, pre-commit.

robbertbos added 1 commit 2026-09-19 14:34:39 +00:00

Indent a quote by its depth, not by its marker's width ... 2f3cd44510

NLDD sizes the hanging indent by the prefix's character count, so once
the marker is hidden `>x` sits one advance in and `> x` two. Indent by
the number of `>` instead, in both caret states, so neither the space
nor the caret moves the text.

The token guard's regexes had no `_`, so no `--_*` variable was ever
checked. This change reads NLDD's internal --_marker-advance, so the
guard now covers it.

robbertbos merged commit 2f3cd44510 into main 2026-09-19 14:39:57 +00:00

robbertbos deleted branch quote-indent-by-depth 2026-09-19 14:39:57 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

nldd ds

  

question

More information is needed

  

wontfix

This won't be fixed

No labels

bug

duplicate

enhancement

help wanted

invalid

nldd ds

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

robbertbos/waggle!364

No description provided.