Preview attachments in Postvak and Meelezen #467

Merged

robbertbos merged 3 commits from postvak-attachment-previews into main 2026-09-28 20:35:39 +00:00

Conversation 0 Commits 3 Files changed 9 +130 -50

robbertbos commented 2026-09-28 18:55:38 +00:00

Owner

Copy link

A non-image attachment on a Postvak or Meelezen message was a plain link to the file proxy. The proxy serves HTML as a download on purpose (the rendered view only exists behind ?preview=html), so an HTML report never previewed. MessageItem now draws the file cards AttachmentPreview already gives a card: HTML opens in the sandboxed preview, PDF, text and video in theirs, and every file keeps its download button.

MessageItem also draws the card modal's thread and channel context, so those get the same file cards.

The image viewer now steps to the previous and next image of a message (arrows, counter, ArrowLeft/ArrowRight). ImageLightbox already supported this, but MessageItem only ever handed it the clicked image. It now emits every image of the message with the clicked index. The same wiring is added to the channel context and to the card modal's own message.

The Postvak dev-mock's attachments had no file id (the proxy could not serve them) and no HTML file; both fixed in a separate commit.

Checked in the preview with Playwright: a Postvak row shows the file cards, and clicking rapport.html opens the HTML preview with a sandbox="allow-scripts" iframe on ?preview=html.

A non-image attachment on a Postvak or Meelezen message was a plain link to the file proxy. The proxy serves HTML as a download on purpose (the rendered view only exists behind `?preview=html`), so an HTML report never previewed. `MessageItem` now draws the file cards `AttachmentPreview` already gives a card: HTML opens in the sandboxed preview, PDF, text and video in theirs, and every file keeps its download button. `MessageItem` also draws the card modal's thread and channel context, so those get the same file cards. The image viewer now steps to the previous and next image of a message (arrows, counter, ArrowLeft/ArrowRight). `ImageLightbox` already supported this, but `MessageItem` only ever handed it the clicked image. It now emits every image of the message with the clicked index. The same wiring is added to the channel context and to the card modal's own message. The Postvak dev-mock's attachments had no file id (the proxy could not serve them) and no HTML file; both fixed in a separate commit. Checked in the preview with Playwright: a Postvak row shows the file cards, and clicking `rapport.html` opens the HTML preview with a `sandbox="allow-scripts"` iframe on `?preview=html`.

robbertbos added 2 commits 2026-09-28 18:55:38 +00:00

Give the Postvak dev-mock attachments real ids and an HTML file ... 34b82e3dad

The unread mock's files had no id, so the file proxy could not serve
them, and there was no HTML attachment to open a preview on.

Preview attachments in Postvak and Meelezen ... 6e34e526df

MessageItem drew a non-image file as a plain link to the file proxy,
which serves HTML as a download by design: the rendered view only
exists behind ?preview=html. Draw the file cards AttachmentPreview
already gives a card instead, so HTML, PDF, text and video open in
their preview and every file keeps a download button.

MessageItem also draws the card modal's thread and channel context,
which get the same file cards.

robbertbos referenced this pull request 2026-09-28 19:26:55 +00:00

Keep Postvak and Meelezen replies as concepts #468

robbertbos force-pushed postvak-attachment-previews from 6e34e526df to 7125243e81 2026-09-28 20:07:08 +00:00 Compare

robbertbos merged commit 7125243e81 into main 2026-09-28 20:35:39 +00:00

robbertbos deleted branch postvak-attachment-previews 2026-09-28 20:35:39 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

nldd ds

  

question

More information is needed

  

wontfix

This won't be fixed

No labels

bug

duplicate

enhancement

help wanted

invalid

nldd ds

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

robbertbos/waggle!467

No description provided.