Document why there are more memberships than channels #428

Merged

robbertbos merged 1 commit from mm-archived-memberships into main 2026-09-24 20:19:17 +00:00

Conversation 0 Commits 1 Files changed 2 +13 -2

robbertbos commented 2026-09-23 21:31:56 +00:00

Owner

Copy link

Answers the first question of #400 (why 458 memberships but 420 channels) from the Mattermost server source, at mattermost/mattermost 53211e45b, server/channels/store/sqlstore/channel_store.go:

• GET /users/me/channel_members (GetMembersForUserWithPagination) returns every membership. The only filter is on channel types that carry no messages, so archived channels and channels of a deleted team are included.
• GET /users/me/channels (GetChannelsByUser) adds Channels.DeleteAt = 0 and "team not deleted" unless include_deleted=true.
• The same handler (api4/channel.go, getChannelsForUser) pages internally in steps of 100 and streams the whole list ("the client always needs to get the full data"). That is why it ignores page/per_page, and why it is never truncated.

So the 38 are archived channels or channels of a deleted team. Waggle already gives them no Postvak row: the listing iterates over channels, and the channel-window endpoint reads one as fully read (_UNKNOWN_CHANNEL). That matches Mattermost, which hides archived channels by default. No code change is needed; this PR records the finding in CLAUDE.md's Mattermost gotchas and corrects the _UNKNOWN_CHANNEL comment.

Not addressed, deliberately: the second half of #400, whether muted channels with unread messages should surface in Meelezen. That is a reading-model decision, not something to settle in a patch, so #400 stays open for it.

Docs and a comment only, so no CHANGELOG entry.

Answers the first question of #400 (why 458 memberships but 420 channels) from the Mattermost server source, at `mattermost/mattermost` `53211e45b`, `server/channels/store/sqlstore/channel_store.go`: - `GET /users/me/channel_members` (`GetMembersForUserWithPagination`) returns every membership. The only filter is on channel types that carry no messages, so archived channels and channels of a deleted team are included. - `GET /users/me/channels` (`GetChannelsByUser`) adds `Channels.DeleteAt = 0` and "team not deleted" unless `include_deleted=true`. - The same handler (`api4/channel.go`, `getChannelsForUser`) pages internally in steps of 100 and streams the whole list ("the client always needs to get the full data"). That is why it ignores `page`/`per_page`, and why it is never truncated. So the 38 are archived channels or channels of a deleted team. Waggle already gives them no Postvak row: the listing iterates over channels, and the channel-window endpoint reads one as fully read (`_UNKNOWN_CHANNEL`). That matches Mattermost, which hides archived channels by default. No code change is needed; this PR records the finding in CLAUDE.md's Mattermost gotchas and corrects the `_UNKNOWN_CHANNEL` comment. Not addressed, deliberately: the second half of #400, whether muted channels with unread messages should surface in Meelezen. That is a reading-model decision, not something to settle in a patch, so #400 stays open for it. Docs and a comment only, so no CHANGELOG entry.

robbertbos added 1 commit 2026-09-23 21:31:56 +00:00

Document why there are more memberships than channels ... 07067e147c

/users/me/channel_members returns every membership, including archived
channels and channels of a deleted team; /users/me/channels leaves both
out unless include_deleted=true, and streams its full list, so it is
never truncated. Measured on a real account the surplus was 38 rows;
they are those channels, and getting no Postvak row is right for them.
Verified against mattermost/mattermost at 53211e45b.

robbertbos scheduled this pull request to auto merge when all checks succeed 2026-09-24 05:46:48 +00:00

robbertbos force-pushed mm-archived-memberships from 07067e147c to 949cf4f0dc 2026-09-24 05:46:53 +00:00 Compare

robbertbos force-pushed mm-archived-memberships from 949cf4f0dc to e8290504cb 2026-09-24 20:03:15 +00:00 Compare

robbertbos force-pushed mm-archived-memberships from e8290504cb to 9c1ca9db9f 2026-09-24 20:13:07 +00:00 Compare

robbertbos merged commit 9c1ca9db9f into main 2026-09-24 20:19:17 +00:00

robbertbos deleted branch mm-archived-memberships 2026-09-24 20:19:17 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

nldd ds

  

question

More information is needed

  

wontfix

This won't be fixed

No labels

bug

duplicate

enhancement

help wanted

invalid

nldd ds

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

robbertbos/waggle!428

No description provided.