Warn when the membership walk stops at its page cap #427

Merged

robbertbos merged 1 commit from mm-membership-cap-warning into main 2026-09-24 19:58:21 +00:00

Conversation 0 Commits 1 Files changed 2 +85 -16

robbertbos commented 2026-09-23 21:29:26 +00:00

Owner

Copy link

Closes #402. When list_my_channel_memberships reaches its cap of 50 pages of 200, it now asks for one page more (page 50) and logs mm_memberships_truncated (with pages and memberships) only if that page holds memberships it has not seen yet. The rows of that page stay out of the result, so the cap still bounds what is returned. A walk that ends exactly on 10,000 memberships, or a server that serves repeats past the cap, stays silent; a short page or a page with nothing new stops the walk before the cap and never makes the extra request. The page fetch moved into _membership_page so the extra request shares the 401/4xx handling.

Tests: the cap test asserts the warning and 51 requests; a parametrized test covers ending exactly on the cap (empty page and only-repeats page after it); a normal multi-page walk logs nothing. mattermost.py had no logger yet; it gets a structlog one, like most modules. The line carries request_id through the middleware, which links it to the request line with the pseudonymous user id.

No CHANGELOG entry: an ops log line, nothing a user sees.

Closes #402. When `list_my_channel_memberships` reaches its cap of 50 pages of 200, it now asks for one page more (page 50) and logs `mm_memberships_truncated` (with `pages` and `memberships`) only if that page holds memberships it has not seen yet. The rows of that page stay out of the result, so the cap still bounds what is returned. A walk that ends exactly on 10,000 memberships, or a server that serves repeats past the cap, stays silent; a short page or a page with nothing new stops the walk before the cap and never makes the extra request. The page fetch moved into `_membership_page` so the extra request shares the 401/4xx handling. Tests: the cap test asserts the warning and 51 requests; a parametrized test covers ending exactly on the cap (empty page and only-repeats page after it); a normal multi-page walk logs nothing. `mattermost.py` had no logger yet; it gets a structlog one, like most modules. The line carries `request_id` through the middleware, which links it to the request line with the pseudonymous user id. No CHANGELOG entry: an ops log line, nothing a user sees.

robbertbos added 1 commit 2026-09-23 21:29:26 +00:00

Warn when the membership walk stops at its page cap ... f880a0e7c7

list_my_channel_memberships stops after 50 pages of 200. Past 10,000
memberships it dropped the rest without a word: an incomplete Postvak
and no error anywhere. The walk now logs mm_memberships_truncated when
it leaves on the cap rather than on a short or repeated page.

robbertbos scheduled this pull request to auto merge when all checks succeed 2026-09-23 21:56:59 +00:00

robbertbos force-pushed mm-membership-cap-warning from f880a0e7c7 to 22f8f7edef 2026-09-24 19:47:17 +00:00 Compare

robbertbos force-pushed mm-membership-cap-warning from 22f8f7edef to 78b745c63b 2026-09-24 19:53:03 +00:00 Compare

robbertbos merged commit 78b745c63b into main 2026-09-24 19:58:21 +00:00

robbertbos deleted branch mm-membership-cap-warning 2026-09-24 19:58:21 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

nldd ds

  

question

More information is needed

  

wontfix

This won't be fixed

No labels

bug

duplicate

enhancement

help wanted

invalid

nldd ds

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

robbertbos/waggle!427

No description provided.