Make the frontend tests independent of runner load #425

Merged

robbertbos merged 1 commit from ci-frozen-parse-clock into main 2026-09-23 23:21:43 +00:00

Conversation 0 Commits 1 Files changed 8 +49 -8

robbertbos commented 2026-09-23 21:15:48 +00:00

Owner

Copy link

Closes #404.

frontend-test failed in 14 of the last 85 runs. The failed first attempts could still be read through the job view in the web UI (the raw log download returns a 500 for them). Here is what failed:

Test	Runs
quoteBar.test.ts "marks a quote the initial parse did not reach"	12 (one of them together with hideMarkers.test.ts)
UnreadMessageList.test.ts "stops loading further unread at the window ceiling" (timeout at 5000ms)	1
Node download in setup-node (TLS disconnect)	1, fixed by #420

The failure was always an assertion or a timeout, never a crash, and always a test that depends on the clock.

CodeMirror parse budget. CodeMirror stops parsing when a Date.now() budget runs out: 20ms when a state is created, 50ms in ensureSyntaxTree. On a busy runner the tree stops short, and quoteLines sees no quote at line 400. A clock that jumps 30ms per call reproduces the exact CI error (expected [] to have a length of 1 but got +0); with a frozen clock the test passes. The seven test files that read a parse tree now freeze Date per test (vi.useFakeTimers({ toFake: ['Date'] })). Parsing then stops only on its character limits, so the test still exercises the "initial parse stops at 3000 characters" case it is named after.

UnreadMessageList.test.ts. The fixtures are timed against a NOW pinned at module load, but the component formats "40 min geleden" against the real clock. Once the file had run for more than a minute, the label read "41 min geleden"; setting the clock to NOW + 61s reproduces it. Date is now frozen at NOW. The window-ceiling test renders a full 200-message window (MAX_UNREAD_WINDOW) eight times: 3.1s at load 12, against the 5s default. It gets 20s instead of a smaller window, because hitting the real ceiling is the point of the test.

Test-only change, so no CHANGELOG entry.

Not fixed: in one local run at load 22, SortableSection.test.ts "scrolls a card hanging off the bottom back into view after an Alt-move" also failed once. It is not among the CI failures and I could not reproduce it (a 30ms stall around afterMove passes), so it is left alone. If it shows up in CI, its log is the place to start.

Closes #404. `frontend-test` failed in 14 of the last 85 runs. The failed first attempts could still be read through the job view in the web UI (the raw log download returns a 500 for them). Here is what failed: | Test | Runs | |---|---| | `quoteBar.test.ts` "marks a quote the initial parse did not reach" | 12 (one of them together with `hideMarkers.test.ts`) | | `UnreadMessageList.test.ts` "stops loading further unread at the window ceiling" (timeout at 5000ms) | 1 | | Node download in `setup-node` (TLS disconnect) | 1, fixed by #420 | The failure was always an assertion or a timeout, never a crash, and always a test that depends on the clock. **CodeMirror parse budget.** CodeMirror stops parsing when a `Date.now()` budget runs out: 20ms when a state is created, 50ms in `ensureSyntaxTree`. On a busy runner the tree stops short, and `quoteLines` sees no quote at line 400. A clock that jumps 30ms per call reproduces the exact CI error (`expected [] to have a length of 1 but got +0`); with a frozen clock the test passes. The seven test files that read a parse tree now freeze `Date` per test (`vi.useFakeTimers({ toFake: ['Date'] })`). Parsing then stops only on its character limits, so the test still exercises the "initial parse stops at 3000 characters" case it is named after. **`UnreadMessageList.test.ts`.** The fixtures are timed against a `NOW` pinned at module load, but the component formats "40 min geleden" against the real clock. Once the file had run for more than a minute, the label read "41 min geleden"; setting the clock to `NOW + 61s` reproduces it. `Date` is now frozen at `NOW`. The window-ceiling test renders a full 200-message window (`MAX_UNREAD_WINDOW`) eight times: 3.1s at load 12, against the 5s default. It gets 20s instead of a smaller window, because hitting the real ceiling is the point of the test. Test-only change, so no CHANGELOG entry. **Not fixed:** in one local run at load 22, `SortableSection.test.ts` "scrolls a card hanging off the bottom back into view after an Alt-move" also failed once. It is not among the CI failures and I could not reproduce it (a 30ms stall around `afterMove` passes), so it is left alone. If it shows up in CI, its log is the place to start.

robbertbos added 1 commit 2026-09-23 21:15:48 +00:00

Make the frontend tests independent of runner load ... 3173f08749

frontend-test failed about one run in six and passed on a retry. Of
the 14 failures still in the Forgejo history, 12 were the CodeMirror
parser tests (11 of them quoteBar's "marks a quote the initial parse
did not reach"). CodeMirror stops parsing when a Date.now() budget
runs out (20ms on state creation, 50ms in ensureSyntaxTree), so on a
busy runner the tree stops short and the test sees no quote. The
tests that read a parse tree now freeze Date, which leaves only the
character limits in play.

UnreadMessageList.test.ts pinned NOW at module load, while the
component formats "40 min geleden" against the real clock: a file
that ran over a minute read "41 min geleden". Date is now frozen at
NOW. Its window-ceiling test renders a full 200-message window eight
times and timed out at the 5s default once; it gets 20s.

robbertbos force-pushed ci-frozen-parse-clock from 3173f08749 to 4e1af240b3 2026-09-23 21:16:19 +00:00 Compare

robbertbos force-pushed ci-frozen-parse-clock from 4e1af240b3 to 0baf416258 2026-09-23 21:22:00 +00:00 Compare

robbertbos scheduled this pull request to auto merge when all checks succeed 2026-09-23 21:39:12 +00:00

robbertbos force-pushed ci-frozen-parse-clock from 0baf416258 to 1c63b3450c 2026-09-23 21:39:17 +00:00 Compare

robbertbos force-pushed ci-frozen-parse-clock from 1c63b3450c to 2796f6fb86 2026-09-23 22:03:11 +00:00 Compare

robbertbos force-pushed ci-frozen-parse-clock from 2796f6fb86 to 46921bf169 2026-09-23 22:18:07 +00:00 Compare

robbertbos merged commit 46921bf169 into main 2026-09-23 23:21:43 +00:00

robbertbos deleted branch ci-frozen-parse-clock 2026-09-23 23:21:43 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

nldd ds

  

question

More information is needed

  

wontfix

This won't be fixed

No labels

bug

duplicate

enhancement

help wanted

invalid

nldd ds

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

robbertbos/waggle!425

No description provided.