Page through every channel membership #401

Merged

robbertbos merged 2 commits from postvak-paginate-channel-memberships into main 2026-09-20 21:59:03 +00:00

Conversation 0 Commits 2 Files changed 3 +117 -29

robbertbos commented 2026-09-20 21:46:58 +00:00

Owner

Copy link

The Postvak came up empty on a production account while Mattermost showed an unread channel. GET /users/me/channel_members pages at 60 without an explicit per_page, and the client read one page. A channel whose membership never arrives is skipped in mm_unread.py (if member is None: continue), so the rows quietly disappear and the endpoint answers {"items":[]} with a 200.

Measured on that account: 458 memberships, 60 fetched, and the only non-muted unread channel sat outside them.

The walk asks for 200 per page and stops on a short page. It also stops on a page that adds no new ids, because /users/me/channels ignores paging and serves the full list for every page - a short-page check alone never terminates against that. A 50-page cap bounds it either way.

Tests

Three, all in test_mattermost_unread_client.py: the walk collects 250 rows across pages (fails before this change with first extra item: 'c60'), it terminates against an endpoint that ignores paging, and it stops at the cap. The existing URL assertion moves to the paged URL.

Found while debugging, not in this PR

• resolve_crt_enabled reads the collapsed-reply-threads preference from /preferences/display/collapsed_reply_threads. Mattermost serves it at /preferences/display_settings/name/collapsed_reply_threads: wrong category, and the /name/ segment is missing. The 404 that comes back is read as "not set", which under CollapsedThreads: default_on resolves to on - which happens to be the right answer today, so nothing shows. Turn CRT off and the Postvak empties again.
• That route answers 400, not 404, for a preference that does not exist. get_user_preference only translates 404, so fixing the URL alone turns the silent default into a 502.
• Two open questions filed as #400: 38 memberships without a channel row, and muted channels with unread messages surfacing in neither the Postvak nor Meelezen.

The Postvak came up empty on a production account while Mattermost showed an unread channel. `GET /users/me/channel_members` pages at 60 without an explicit `per_page`, and the client read one page. A channel whose membership never arrives is skipped in `mm_unread.py` (`if member is None: continue`), so the rows quietly disappear and the endpoint answers `{"items":[]}` with a 200. Measured on that account: 458 memberships, 60 fetched, and the only non-muted unread channel sat outside them. The walk asks for 200 per page and stops on a short page. It also stops on a page that adds no new ids, because `/users/me/channels` ignores paging and serves the full list for every page - a short-page check alone never terminates against that. A 50-page cap bounds it either way. ### Tests Three, all in `test_mattermost_unread_client.py`: the walk collects 250 rows across pages (fails before this change with `first extra item: 'c60'`), it terminates against an endpoint that ignores paging, and it stops at the cap. The existing URL assertion moves to the paged URL. ### Found while debugging, not in this PR - `resolve_crt_enabled` reads the collapsed-reply-threads preference from `/preferences/display/collapsed_reply_threads`. Mattermost serves it at `/preferences/display_settings/name/collapsed_reply_threads`: wrong category, and the `/name/` segment is missing. The 404 that comes back is read as "not set", which under `CollapsedThreads: default_on` resolves to on - which happens to be the right answer today, so nothing shows. Turn CRT off and the Postvak empties again. - That route answers 400, not 404, for a preference that does not exist. `get_user_preference` only translates 404, so fixing the URL alone turns the silent default into a 502. - Two open questions filed as #400: 38 memberships without a channel row, and muted channels with unread messages surfacing in neither the Postvak nor Meelezen.

robbertbos added 1 commit 2026-09-20 21:46:58 +00:00

Page through every channel membership ... 1010a022e2

Mattermost serves /users/me/channel_members 60 rows at a time. The client
read one page, so a user in more channels lost the rest: the Postvak
skipped every channel whose membership never arrived, down to an empty
list while Mattermost showed unread messages.

Measured on production: 458 memberships, 60 fetched, and the one unread
channel sat outside them.

The walk also stops on a page that adds no new ids. The sibling endpoint
/users/me/channels ignores paging and serves the full list for every
page; a short-page check alone would loop forever against that.

robbertbos added 1 commit 2026-09-20 21:50:37 +00:00

Drop the Dutch word from the changelog heading 6daa27a000

robbertbos force-pushed postvak-paginate-channel-memberships from 6daa27a000 to 3585b0220c 2026-09-20 21:52:49 +00:00 Compare

robbertbos added 1 commit 2026-09-20 21:54:11 +00:00

Shorten the scale-to-zero changelog entry a8b164c9d5

robbertbos referenced this pull request 2026-09-20 21:56:28 +00:00

The membership page cap truncates silently #402

robbertbos merged commit a8b164c9d5 into main 2026-09-20 21:59:03 +00:00

robbertbos deleted branch postvak-paginate-channel-memberships 2026-09-20 21:59:03 +00:00

robbertbos referenced this pull request 2026-09-20 22:01:16 +00:00

Prepare the v2026.9.21 release #403

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

nldd ds

  

question

More information is needed

  

wontfix

This won't be fixed

No labels

bug

duplicate

enhancement

help wanted

invalid

nldd ds

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

robbertbos/waggle!401

No description provided.