Put marked behind Dependency Dashboard approval #381

Merged

robbertbos merged 1 commit from marked-behind-dashboard-approval into main 2026-09-20 06:11:23 +00:00

Conversation 0 Commits 1 Files changed 2 +7 -2

robbertbos commented 2026-09-20 06:09:52 +00:00

Owner

Copy link

marked stays pinned to 18.0.8 and Renovate stops opening a PR for it; the newest release is listed on the Dependency Dashboard (#10) instead, behind a checkbox.

Measured on #377 (18.0.13) before closing it: src/lib/markdown.test.ts fails 3 of 30, > citaat / >> / tekst renders as two empty blockquotes with tekst gone. Upstream markedjs/marked#4098 is open and neither fix PR is merged, so every release from 18.0.9 on carries it, and the weekly PR is one our own regression test is only ever going to fail.

Approval rather than allowedVersions: "<18.0.9" because a silent hold outlives its reason: the dashboard keeps showing what is available, so the moment a release carries the fix, ticking the box opens the PR.

Verified with renovate-config-validator (passes; a deliberately bogus key in the same rule fails it, so the check is looking inside packageRules) and against the option's own documentation, which gives this exact per-package pattern.

marked stays pinned to 18.0.8 and Renovate stops opening a PR for it; the newest release is listed on the Dependency Dashboard (#10) instead, behind a checkbox. Measured on #377 (18.0.13) before closing it: `src/lib/markdown.test.ts` fails 3 of 30, `> citaat` / `>>` / `tekst` renders as two empty blockquotes with `tekst` gone. Upstream [markedjs/marked#4098](https://github.com/markedjs/marked/issues/4098) is open and neither fix PR is merged, so every release from 18.0.9 on carries it, and the weekly PR is one our own regression test is only ever going to fail. Approval rather than `allowedVersions: "<18.0.9"` because a silent hold outlives its reason: the dashboard keeps showing what is available, so the moment a release carries the fix, ticking the box opens the PR. Verified with `renovate-config-validator` (passes; a deliberately bogus key in the same rule fails it, so the check is looking inside `packageRules`) and against the option's own documentation, which gives this exact per-package pattern.

robbertbos added 1 commit 2026-09-20 06:09:52 +00:00

Put marked behind Dependency Dashboard approval ... 8cf7a8683c

markedjs/marked#4098 is still open and every release from 18.0.9 on
carries the bug, so the weekly PR is a PR markdown.test.ts is only ever
going to fail. Approval keeps the newest release listed on the dashboard
without opening it, so the block cannot outlive its reason the way an
allowedVersions hold can.

robbertbos merged commit 8cf7a8683c into main 2026-09-20 06:11:23 +00:00

robbertbos deleted branch marked-behind-dashboard-approval 2026-09-20 06:11:23 +00:00

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

nldd ds

  

question

More information is needed

  

wontfix

This won't be fixed

No labels

bug

duplicate

enhancement

help wanted

invalid

nldd ds

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

robbertbos/waggle!381

No description provided.