Fix the onboarding data migration on Postgres #136

Merged

robbertbos merged 1 commit from fix/onboarding-migration-postgres into main 2026-07-19 22:06:26 +00:00

Conversation 0 Commits 1 Files changed 2 +26 -16

robbertbos commented 2026-07-19 21:48:57 +00:00

Owner

Copy link

The onboarding data migration (c1f0a7d92b41, merged with the coach-marks PR) compares and assigns the json column hints_seen with raw SQL strings. SQLite treats json as text and accepts it; Postgres has no = operator for the json type and does not implicitly cast a varchar bind parameter on assignment, so alembic upgrade head fails while planning the statement.

Because sync_runner._ensure_schema() runs upgrade head in the FastAPI lifespan, a deploy from current main would fail to boot the pod on Postgres (ZAD).

Found by the new migration-test harness on the fase-1-fundament-v2 branch (PR #123): its backend-test-postgres job went red on exactly this. That is the class of bug the harness was built to catch - the revision passes on SQLite and fails on Postgres.

Fix

Rewritten with typed SQLAlchemy constructs: a sa.table with a sa.JSON column (so the bind parameter is serialized and typed correctly on both dialects) and an explicit CAST(hints_seen AS TEXT) for the comparisons. Semantics unchanged: only rows with an empty/NULL hints_seen belonging to users with a connected account are marked, and re-running stays a no-op.

Verified

• upgrade head -> downgrade base -> upgrade head against Postgres 17: clean.
• The 6 migration tests from the fase-1-fundament-v2 branch: green on SQLite and Postgres with this fix (they fail on Postgres without it).
• Full backend suite: 1337 passed.

After merge, PR #123 needs one more rebase to pick this up; its own migration re-parents onto this chain.

The onboarding data migration (`c1f0a7d92b41`, merged with the coach-marks PR) compares and assigns the `json` column `hints_seen` with raw SQL strings. SQLite treats json as text and accepts it; Postgres has no `=` operator for the `json` type and does not implicitly cast a `varchar` bind parameter on assignment, so `alembic upgrade head` fails while planning the statement. Because `sync_runner._ensure_schema()` runs `upgrade head` in the FastAPI lifespan, a deploy from current main would fail to boot the pod on Postgres (ZAD). Found by the new migration-test harness on the `fase-1-fundament-v2` branch (PR #123): its `backend-test-postgres` job went red on exactly this. That is the class of bug the harness was built to catch - the revision passes on SQLite and fails on Postgres. ## Fix Rewritten with typed SQLAlchemy constructs: a `sa.table` with a `sa.JSON` column (so the bind parameter is serialized and typed correctly on both dialects) and an explicit `CAST(hints_seen AS TEXT)` for the comparisons. Semantics unchanged: only rows with an empty/NULL `hints_seen` belonging to users with a connected account are marked, and re-running stays a no-op. ## Verified - `upgrade head` -> `downgrade base` -> `upgrade head` against Postgres 17: clean. - The 6 migration tests from the fase-1-fundament-v2 branch: green on SQLite and Postgres with this fix (they fail on Postgres without it). - Full backend suite: 1337 passed. After merge, PR #123 needs one more rebase to pick this up; its own migration re-parents onto this chain.

robbertbos added 1 commit 2026-07-19 21:48:57 +00:00

Fix the onboarding data migration on Postgres ... 9cdf70822b

The raw-SQL text comparison on hints_seen has no = operator for the json
type on Postgres, and the varchar bind parameter is not implicitly cast on
assignment either. The migration runs at application startup, so a deploy
from current main would fail to boot the pod.

Rewritten with typed SQLAlchemy constructs (JSON column, explicit CAST to
TEXT for the comparisons), which render correctly on both SQLite and
Postgres. Verified with upgrade/downgrade/upgrade against Postgres 17 and
the migration test suite from the fase-1-fundament-v2 branch.

robbertbos referenced this pull request 2026-07-19 21:49:12 +00:00

Make the owner of an outgoing post a database guarantee #123

robbertbos referenced this pull request from a commit 2026-07-19 21:57:54 +00:00

Fix the onboarding data migration on Postgres (same fix as #136)

robbertbos merged commit 9cdf70822b into main 2026-07-19 22:06:26 +00:00

robbertbos deleted branch fix/onboarding-migration-postgres 2026-07-19 22:06:26 +00:00

robbertbos referenced this pull request from a commit 2026-07-19 22:08:12 +00:00

Merge main (migration fix #136 landed there; identical content)

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels

No items

No labels

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

robbertbos/waggle!136

No description provided.