Use nldd-icon-button for the card-detail modal source link #239
Loading…
Add table
Add a link
Reference in a new issue
No description provided.
Delete branch "style/modal-header-icon-button"
Deleting a branch is permanent. Although the deleted branch may continue to exist for a short time before it actually gets removed, it CANNOT be undone in most cases. Continue?
The card-detail modal header held two controls at very different sizes.
Modal.vue)Modal.vue:85renders the close button as annldd-icon-buttonwith nosize, so it gets NLDD'smddefault. The source link was hand-rolled with its own box, its own hover rule and its own colour.The swap
nldd-icon-buttonsupplies all of it, so the 15 lines of.iconButtonCSS go with it. Nosizeattribute, matching the close button: both land onmd, the header stays 60px, and NLDD usesneutral-transparentatmdfor a panel dismissal in its own components (banner,just-in-time-education).:reland:titlefall away - the component setsrel="noopener noreferrer"undertarget="_blank"and renders its own tooltip from the accessible label.If you want them smaller instead
size="sm"on both would make the header 49px instead of 60px, but that shrinks it in Sneltoetsen, RecoveryKey and ComposeOverlay too, since they shareModal.vue. Worth deciding deliberately rather than as a side effect; not done here.Verification
vue-tsc, eslint (0 errors), vitest 691 in 94 files,vite build.25179d5d5273a30f3fbaClosing: this is being handled elsewhere, like #236.
What was in here: the card-detail modal header had two controls at very different sizes.
Modal.vue's close button is annldd-icon-buttonwith nosize, so NLDD'smddefault (44x44, 24px icon); the "Open in Mattermost" link beside it was hand-rolled at 24x24 with a 16px icon, and it was the only one of the two with a hover plate and the link cursor.The change made it an
nldd-icon-buttonwith no size attribute, matching the close button, and dropped the 15 lines of.iconButtonCSS.:reland:titlefall away because the component setsrel="noopener noreferrer"undertarget="_blank"and renders its own tooltip from the accessible label.One thing to decide if you want them smaller instead:
size="sm"on both makes the header 49px instead of 60px, butModal.vueis shared, so that also shrinks Sneltoetsen, RecoveryKey and ComposeOverlay. Worth deciding deliberately rather than as a side effect.Opgegaan in #245, samen met #236 en #242. De commit is ongewijzigd overgenomen.
Pull request closed