Restore the pill shape on the section count badges #202

Merged

robbertbos merged 1 commit from fix-retired-radius-token into main 2026-07-26 20:04:11 +00:00

Conversation 0 Commits 1 Files changed 2 +2 -2

robbertbos commented 2026-07-26 19:53:03 +00:00

Owner

Copy link

#196 retired --radius-full but missed two consumers: the count badge beside a section header in QueuedSection.vue and SortableSection.vue.

Neither reference has a fallback, so border-radius: var(--radius-full) is an invalid declaration and the browser drops it entirely. The badge renders square where a pill was intended.

Found while checking whether fase-5-composer still referenced the retired tokens - it does not any more, but main did.

Why nothing caught it

A retired custom property fails silently by construction. There is no error, no warning, and no failing test; vue-tsc does not look inside CSS variable names. The only signal is visual.

A grep for every token #196 retired (--space-*, --text-*, --radius-*, --font-weight-*, --shadow-*, --transition-*, --line-height-*, --focus-ring) now returns nothing across frontend/src.

Verified

vue-tsc clean, 534 tests green, build green.

#196 retired `--radius-full` but missed two consumers: the count badge beside a section header in `QueuedSection.vue` and `SortableSection.vue`. Neither reference has a fallback, so `border-radius: var(--radius-full)` is an invalid declaration and the browser drops it entirely. The badge renders square where a pill was intended. Found while checking whether `fase-5-composer` still referenced the retired tokens - it does not any more, but `main` did. ## Why nothing caught it A retired custom property fails silently by construction. There is no error, no warning, and no failing test; `vue-tsc` does not look inside CSS variable names. The only signal is visual. A grep for every token `#196` retired (`--space-*`, `--text-*`, `--radius-*`, `--font-weight-*`, `--shadow-*`, `--transition-*`, `--line-height-*`, `--focus-ring`) now returns nothing across `frontend/src`. ## Verified `vue-tsc` clean, 534 tests green, build green.

robbertbos added 1 commit 2026-07-26 19:53:03 +00:00

Restore the pill shape on the section count badges ... e096a000ad

#196 retired --radius-full but missed two consumers. Neither has a fallback, so
the whole border-radius declaration was invalid and dropped: the count badge
beside a section header rendered square instead of a pill.

Silent by construction - no error, no failing test, and typecheck does not look
at CSS variable names. A grep for every retired token now returns nothing across
src.

robbertbos referenced this pull request 2026-07-26 19:56:29 +00:00

Nothing catches a reference to a CSS custom property that no longer exists #204

robbertbos merged commit a3061a0331 into main 2026-07-26 20:04:11 +00:00

robbertbos deleted branch fix-retired-radius-token 2026-07-26 20:04:11 +00:00

robbertbos referenced this pull request 2026-07-26 20:34:02 +00:00

Fix the CSS defects the NLDD migration left behind #207

Sign in to join this conversation.

Reviewers

No reviewers

Labels

Clear labels   

bug

Something is not working

  

duplicate

This issue or pull request already exists

  

enhancement

New feature

  

help wanted

Need some help

  

invalid

Something is wrong

  

nldd ds

  

question

More information is needed

  

wontfix

This won't be fixed

No labels

bug

duplicate

enhancement

help wanted

invalid

nldd ds

question

wontfix

Milestone

Clear milestone

No items

No milestone

Projects

Clear projects

No items

No project

Assignees

Clear assignees

No assignees

1 participant

Notifications

Subscribe

Due date

The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference

robbertbos/waggle!202

No description provided.