robbertbos/waggle
robbertbos/waggle
1
0
Fork 0
Code Issues 1 Pull requests 3 Releases 14 Packages 2 Activity Actions

Fase 3 — toegankelijkheids-fundering (shadow-DOM sneltoets-bewaker, focus-trap, plan-popover) #178

Merged
robbertbos merged 2 commits from fase-3-toegankelijkheid-v2 into main 2026-07-25 11:18:21 +00:00
Conversation 0 Commits 2 Files changed 17 +613 -111
robbertbos commented 2026-07-24 07:08:58 +00:00
Owner
Copy link

Fase 3 — toegankelijkheids-fundering

Derde fase van de "nieuw bericht opstellen + plannen"-keten, op main gerebased.
Frontend-only WCAG-fundering die latere fasen (de composer, de plan-popover)
nodig hebben.

Wat

  • Shadow-DOM-bewuste sneltoets-bewaker — lib/editableTarget.ts deelt één
    isEditableTarget(e) die via composedPath()[0] door de shadow-DOM heen kijkt.
    useGlobalSearchShortcut en useCardKeyboardNav deduppen hierop, zodat een
    losse-letter-sneltoets (/) niet meer afgaat terwijl je typt in een veld dat
    in een NLDD web-component zit (WCAG 2.1.4).
  • Focus-trap over shadow-roots + contenteditable — useFocusTrap liep
    eerder langs knoppen in web-components en de Tiptap-editor heen, waardoor Tab
    naar de achtergrond kon weglopen; deepActiveElement() en het aflopen van
    shadow-roots verhelpen dat (WCAG 2.4.3).
  • Plan-/snooze-popover toetsenbord-bedienbaar — TimePresetPicker was een
    muis-only role="menu"; nu role="dialog" met eigen focus-trap, focus-return
    naar de knop, en Escape sluit alleen de popover (WCAG 2.1.1). SendButton en
    BubbleMenuButton krijgen aria-haspopup="dialog".

Gates

  • Frontend: tsc schoon, vitest 531/531 groen, build ok, eslint 0 errors.
  • Pre-commit: alle hooks groen.

Geen backend-wijzigingen.

## Fase 3 — toegankelijkheids-fundering Derde fase van de "nieuw bericht opstellen + plannen"-keten, op main gerebased. Frontend-only WCAG-fundering die latere fasen (de composer, de plan-popover) nodig hebben. ### Wat - **Shadow-DOM-bewuste sneltoets-bewaker** — `lib/editableTarget.ts` deelt één `isEditableTarget(e)` die via `composedPath()[0]` door de shadow-DOM heen kijkt. `useGlobalSearchShortcut` en `useCardKeyboardNav` deduppen hierop, zodat een losse-letter-sneltoets (`/`) niet meer afgaat terwijl je typt in een veld dat in een NLDD web-component zit (WCAG 2.1.4). - **Focus-trap over shadow-roots + contenteditable** — `useFocusTrap` liep eerder langs knoppen in web-components en de Tiptap-editor heen, waardoor Tab naar de achtergrond kon weglopen; `deepActiveElement()` en het aflopen van shadow-roots verhelpen dat (WCAG 2.4.3). - **Plan-/snooze-popover toetsenbord-bedienbaar** — `TimePresetPicker` was een muis-only `role="menu"`; nu `role="dialog"` met eigen focus-trap, focus-return naar de knop, en Escape sluit alleen de popover (WCAG 2.1.1). `SendButton` en `BubbleMenuButton` krijgen `aria-haspopup="dialog"`. ### Gates - Frontend: `tsc` schoon, vitest 531/531 groen, build ok, eslint 0 errors. - Pre-commit: alle hooks groen. Geen backend-wijzigingen.
robbertbos force-pushed fase-3-toegankelijkheid-v2 from cc76e60d50
All checks were successful
CI / pre-commit (pull_request) Successful in 55s
Details
CI / frontend-test (pull_request) Successful in 5m23s
Details
CI / release-scripts (pull_request) Successful in 10s
Details
security-scan / Python SCA (pip-audit) (pull_request) Successful in 59s
Details
security-scan / Python SAST (bandit) (pull_request) Successful in 39s
Details
security-scan / JS SCA (npm audit) (pull_request) Successful in 44s
Details
CI / backend-test (pull_request) Successful in 8m44s
Details
security-scan / SBOM (trivy) (pull_request) Successful in 16s
Details
security-scan / Filesystem scan (trivy fs) (pull_request) Successful in 24s
Details
CI / e2e (pull_request) Successful in 8m58s
Details
CI / backend-test-postgres (pull_request) Successful in 9m42s
Details
test-build / build (backend) (pull_request) Successful in 1m58s
Details
test-build / build (frontend) (pull_request) Successful in 2m15s
Details
test-build / build (pull_request) Successful in 0s
Details
to bfa51257b1
All checks were successful
CI / pre-commit (pull_request) Successful in 50s
Details
CI / frontend-test (pull_request) Successful in 5m31s
Details
CI / release-scripts (pull_request) Successful in 10s
Details
CI / backend-test (pull_request) Successful in 6m41s
Details
security-scan / Python SCA (pip-audit) (pull_request) Successful in 58s
Details
security-scan / Python SAST (bandit) (pull_request) Successful in 39s
Details
security-scan / JS SCA (npm audit) (pull_request) Successful in 40s
Details
security-scan / SBOM (trivy) (pull_request) Successful in 15s
Details
security-scan / Filesystem scan (trivy fs) (pull_request) Successful in 22s
Details
CI / backend-test-postgres (pull_request) Successful in 8m34s
Details
CI / e2e (pull_request) Successful in 8m23s
Details
test-build / build (backend) (pull_request) Successful in 1m58s
Details
test-build / build (frontend) (pull_request) Successful in 2m14s
Details
test-build / build (pull_request) Successful in 0s
Details
2026-07-24 16:29:45 +00:00 Compare
robbertbos force-pushed fase-3-toegankelijkheid-v2 from 0442f83d05
All checks were successful
CI / pre-commit (pull_request) Successful in 52s
Details
CI / frontend-test (pull_request) Successful in 5m2s
Details
CI / release-scripts (pull_request) Successful in 10s
Details
CI / backend-test (pull_request) Successful in 6m55s
Details
security-scan / Filesystem scan (trivy fs) (pull_request) Successful in 25s
Details
security-scan / JS SCA (npm audit) (pull_request) Successful in 41s
Details
security-scan / SBOM (trivy) (pull_request) Successful in 16s
Details
CI / e2e (pull_request) Successful in 8m27s
Details
test-build / build (frontend) (pull_request) Successful in 2m5s
Details
security-scan / Python SCA (pip-audit) (pull_request) Successful in 59s
Details
security-scan / Python SAST (bandit) (pull_request) Successful in 38s
Details
CI / backend-test-postgres (pull_request) Successful in 8m39s
Details
test-build / build (backend) (pull_request) Successful in 1m52s
Details
test-build / build (pull_request) Successful in 0s
Details
to 6b4bbef71c
All checks were successful
CI / pre-commit (pull_request) Successful in 56s
Details
CI / frontend-test (pull_request) Successful in 4m52s
Details
CI / release-scripts (pull_request) Successful in 10s
Details
security-scan / Python SCA (pip-audit) (pull_request) Successful in 59s
Details
security-scan / Python SAST (bandit) (pull_request) Successful in 37s
Details
CI / backend-test (pull_request) Successful in 6m53s
Details
security-scan / Filesystem scan (trivy fs) (pull_request) Successful in 24s
Details
security-scan / JS SCA (npm audit) (pull_request) Successful in 40s
Details
security-scan / SBOM (trivy) (pull_request) Successful in 17s
Details
CI / backend-test-postgres (pull_request) Successful in 8m50s
Details
test-build / build (backend) (pull_request) Successful in 1m53s
Details
CI / e2e (pull_request) Successful in 8m26s
Details
test-build / build (frontend) (pull_request) Successful in 2m12s
Details
test-build / build (pull_request) Successful in 0s
Details
2026-07-25 10:58:02 +00:00 Compare
robbertbos deleted branch fase-3-toegankelijkheid-v2 2026-07-25 11:18:21 +00:00
Sign in to join this conversation.
Reviewers
No reviewers
Labels
Clear labels   
bug
Something is not working

  
duplicate
This issue or pull request already exists

  
enhancement
New feature

  
help wanted
Need some help

  
invalid
Something is wrong

  
nldd ds

   
question
More information is needed

  
wontfix
This won't be fixed

No labels
bug
duplicate
enhancement
help wanted
invalid
nldd ds
question
wontfix
Milestone
Clear milestone
No items
No milestone
Projects
Clear projects
No items
No project
Assignees
Clear assignees
No assignees
1 participant
Notifications
Due date
The due date is invalid or out of range. Please use the format "yyyy-mm-dd".

No due date set.

Dependencies

No dependencies set.

Reference
robbertbos/waggle!178
No description provided.